LLNL / H5Z-ZFP

A registered ZFP compression plugin for HDF5
Other
50 stars 22 forks source link

Enable CMake testing #110

Closed brtnfld closed 1 year ago

brtnfld commented 1 year ago

Enable CMake testing:

lrknox commented 1 year ago

After setting HDF5_DIR and ZFP_DIR, creating a build subdirectory and running "CC=gcc FC=gfortran cmake -DCMAKE_INSTALL_PREFIX=/mnt/wrk/lrknox/h5z-zfp_install .." in the build directory (which succeeds), running either "make install" or running "cmake --build . --config Release" produced the following error:

[100%] Linking C executable print_h5repack_farg /usr/bin/ld: CMakeFiles/test_write_plugin.dir/test_write.c.o: undefined reference to symbol 'exp@@GLIBC_2.2.5' //usr/lib64/libm.so.6: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status gmake[2]: [test/test_write_plugin] Error 1 gmake[1]: [test/CMakeFiles/test_write_plugin.dir/all] Error 2

This was with CMake 3.22.1 and GCC 10.2.0 modules on centOS7 (jelly).

brtnfld commented 1 year ago

Probably need to add ${CMAKE_DL_LIBS} to target_link_libraries()

markcmiller86 commented 1 year ago

Ok, am returning my attention to this for a week. Where are we at with this? Is it still a work in progress?

lrknox commented 1 year ago

Ok, am returning my attention to this for a week. Where are we at with this? Is it still a work in progress?

Yes, it is still work in progress. For the most part this one will be superseded by #111, which needs an additional macro to find HDF5 that was built by autotools. It finds HDF5 built with CMake.

brtnfld commented 1 year ago

Closing, replaced by PR #111