search

LLNL / MACSio

A Multi-purpose, Application-Centric, Scalable I/O Proxy Application
https://computing.llnl.gov/projects/co-design/macsio
Other
34 stars 16 forks source link

Eliminate HAVE_MPI conditional compilation #18

Open markcmiller86 opened 5 years ago

markcmiller86 commented 5 years ago

We made the MPI code conditionally compiled originally on the idea that maybe multiple forms of parallelism would be supported here. But, do we expect to be doing anything useful at large scale without MPI? If not, having MPI conditionally compiled only complicates the code without much benefit and it should be removed.

markcmiller86 commented 5 years ago

So, my last commit just made this problem a bit worse. I added a bunch of conditional compilaton to make the code compile in serial. That seemed useful for debugging vaarious issues.