search

LLNL / MuyGPyS

A fast, pure python implementation of the MuyGPs Gaussian process realization and training algorithm.
Other
25 stars 11 forks source link

Fix develop tests being skipped #151

Closed igoumiri closed 1 year ago

igoumiri commented 1 year ago

Fixes https://github.com/LLNL/MuyGPyS/issues/150

igoumiri commented 1 year ago

Tests are failing but kind of randomly.

bwpriest commented 1 year ago

This actually explains something odd Alec and I noticed last week, but I didn't realize the problem was in the CI chassis.

Tests are failing but kind of randomly.

The tests that are failing do so because they are optimizing while we check to see if the output is within some tolerance of the desired answer. There is some randomization, so if we sample a bad batch or something the error can be over the tolerance. We might need to increase the tolerances, since we run these tests so many times.

bwpriest commented 1 year ago

I think you can also guard against the multivariate error by changing

https://github.com/LLNL/MuyGPyS/blob/5313d4bebfe057c29430f757e88130b928429b8a/tests/multivariate.py#L367

to 

self.assertLessEqual(mse, 0.25)