search

LLNL / RAJA

RAJA Performance Portability Layer (C++)
BSD 3-Clause "New" or "Revised" License
489 stars 103 forks source link

blueos reducer reset test failure with gcc #1139

Open rhornung67 opened 3 years ago

rhornung67 commented 3 years ago

The RAJA unit test 'test-reducer-reset-seq.exe' fails reliably when the code is built with gcc and nvcc (note: only sequential version). The same test passes with other host compilers. Any thoughts on this?

rchen20 commented 3 years ago

There is usually a missing compiler flag for this problem: https://github.com/LLNL/RAJA/pull/1073#issuecomment-857750887. Although @trws's reaction in that thread indicates that there may be a more serious problem with something being inlined out, in order for the test to work.

rhornung67 commented 3 years ago

Thanks @rchen20 I forgot about that. I'll try adding that compiler option.

trws commented 3 years ago

Do you have error output for when the test fails? I checked over in the other issue and can’t seem to find an instance of the failure in the azure logs.

On 20 Oct 2021, at 15:24, Rich Hornung wrote:

Thanks @rchen20 I forgot about that. I'll try adding that compiler option.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/LLNL/RAJA/issues/1139*issuecomment-948082553__;Iw!!G2kpM7uM-TzIFchu!kMXAPm7dTD0idYCyZp2c2H1np9TbIdizqnHMV2AiFjS_PRkLSihl8yMe2fbclyCY2g$

rhornung67 commented 3 years ago

I would have to rerun. This may have come up in CI discussion before (I can't recall) and the compiler flag @rchen20 referred to may have been added in the appropriate location. I'll do some more exploration with that option and report back.

rchen20 commented 3 years ago

I'll need to check, but I think in certain places the Gitlab CI files are missing that flag (which I thought I had fixed a while ago).