LLNL / RAJA

RAJA Performance Portability Layer (C++)

BSD 3-Clause "New" or "Revised" License

450 stars 102 forks source link

Add atomicLoad and atomicStore #1663

Closed adayton1 closed 3 weeks ago

adayton1 commented 1 month ago

Summary

This PR is a feature
It does the following:
- Adds atomicLoad and atomicStore at the request of myself
- Adds *.swp files to gitignore list

MrBurmark commented 1 month ago

How about atomicStore too?

adayton1 commented 1 month ago

How about atomicStore too?

I was going to ask about that. It looks like we already have atomicExchange - should atomicStore just be an alias to atomicExchange? Or should atomicStore not return the old value? We have the old value, so I see no reason not to return it, though.

MrBurmark commented 1 month ago

Ya the non-returning part of atomicStore is what makes it different. Some architectures have an atomicStore that is a bit faster because it doesn't return anything.

adayton1 commented 1 month ago

Ya the non-returning part of atomicStore is what makes it different. Some architectures have an atomicStore that is a bit faster because it doesn't return anything.

I've added atomicStore now.

adayton1 commented 4 weeks ago

It's taking forever to get an allocation on poodle. Is that normal?

rhornung67 commented 4 weeks ago

It's taking forever to get an allocation on poodle. Is that normal?

It could be bogged down with folks running jobs. Poodle is usually pretty quick.

rhornung67 commented 3 weeks ago

@adayton1 I restarted the tioga CI jobs when the machine came back up. All checks are green and this is approved. Please feel free to merge.