LLNL / RAJA

RAJA Performance Portability Layer (C++)
BSD 3-Clause "New" or "Revised" License
450 stars 102 forks source link

Fix builds with RAJA as submodule #1687

Closed adayton1 closed 1 week ago

adayton1 commented 1 week ago

Summary

rhornung67 commented 1 week ago

@adayton1 I'd like someone with more CMake expertise than me to also weigh in on this. I added @davidbeckingsale to review. I can't seem to add Chris.

adayton1 commented 1 week ago

This is the error I'm getting in CHAI:

[error]#8 2.837 CMake Error: File /home/chai/workspace/test/CTestCustom.cmake does not exist.

[error]#8 2.837 CMake Error at src/tpl/raja/test/CMakeLists.txt:20 (configure_file):

[error]#8 2.837 configure_file Problem configuring file

mdavis36 commented 1 week ago

@rhornung67 FWIW This looks correct to me, we have to use CURRENT in our submodule structure. CMake tries to use the root directory of the "master" project and will not reference the root directory of a given submodule so using the CURRENT variant of these variables is a safer way of doing this.

rhornung67 commented 1 week ago

Thank you @mdavis36