Issues found in MultiReduce PR

LLNL / RAJAPerf

RAJA Performance Suite

BSD 3-Clause "New" or "Revised" License

110 stars 39 forks source link

Issues found in MultiReduce PR #463

Closed MrBurmark closed 1 month ago

MrBurmark commented 1 month ago

There were several issues found or created in the MultiReduce PR #419.

[x] Environment variables used for input instead of command line arguments
[x] default tuning names sometimes contain tuning parameter values, which makes it unnecessarily difficult to compare across different backends when defaults are used

MrBurmark commented 1 month ago

In the Apps_FIR kernel FIR_COEFFLEN is a #define but there is also a member variable m_coefflen that is set to FIR_COEFFLEN. Does it ever make sense for m_coefflen to be less than FIR_COEFFLEN? If not it would be better to only ever use FIR_COEFFLEN so the extent of the filter is known at compile time.