search

LLNL / SAMRAI

Structured Adaptive Mesh Refinement Application Infrastructure - a scalable C++ framework for block-structured AMR application development
https://computing.llnl.gov/projects/samrai
Other
220 stars 80 forks source link

std::iterator deprecated in C++17 - error with -Werror with gcc 13.2.1 #238

Closed nicolasaunai closed 10 months ago

nicolasaunai commented 11 months ago

this code here: https://github.com/LLNL/SAMRAI/blob/11612bcb456baf7a245376462438882505f14b9e/source/SAMRAI/hier/Box.h#L1472

leads to

error: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Werror=deprecated-declarations] with gcc 13.2.1 (fedora 38)

See for instance this blog post

nicolasaunai commented 11 months ago

I also see that on gcc 12.3.1 actually, -Werror=deprecated-declarations

rhornung67 commented 11 months ago

Hopefully this is helpful: https://stackoverflow.com/questions/43268146/why-is-stditerator-deprecated

PhilipDeegan commented 10 months ago

This is done and can be closed