search

LLNL / Silo

Mesh and Field I/O Library and Scientific Database
https://silo.llnl.gov
Other
30 stars 24 forks source link

Missing return in non-void functions #273

Closed StefanBruens closed 1 year ago

StefanBruens commented 2 years ago

https://github.com/LLNL/Silo/blob/2597088f1b0c48873fee8635ce788df0defaf5b2/src/silo/silo.c#L6278-L6285 ... https://github.com/LLNL/Silo/blob/2597088f1b0c48873fee8635ce788df0defaf5b2/src/silo/silo.c#L6523-L6524

^ Missing return 0;

https://github.com/LLNL/Silo/blob/2597088f1b0c48873fee8635ce788df0defaf5b2/src/silo/silo.c#L6680-L6700

^ Missing return NULL;, or hide the function completely.