Open thesamesam opened 3 months ago
I got another failure with GCC 14 (which makes -Wincompatible-pointer-types
) an error by default, but I'm not familiar enough with this codebase to fix it correctly:
dir.c:203:44: error: passing argument 4 of ‘DBPutMultimesh’ from incompatible pointer type [-Wincompatible-pointer-types]
203 | DBPutMultimesh(dbfile, "mmesh", nmesh, meshnames, meshtypes, NULL);
| ^~~~~~~~~
| |
| char **
In file included from dir.c:64:
./../src/silo/silo.h:2185:84: note: expected ‘const char * const*’ but argument is of type ‘char **’
2185 | SILO_API extern int DBPutMultimesh(DBfile *, char const *, int, char const * const *, int const *,
| ^~~~~~~~~~~~~~~~~~~~
Thanks for the PR. Will review and merge early this coming week.
I got another failure with GCC 14 (which makes
-Wincompatible-pointer-types
) an error by default, but I'm not familiar enough with this codebase to fix it correctly:
Short answer...its missing a cast to DBCAS_t
(constant array of strings) as in
DBPutMultimesh(dbfile, "mmesh", nmesh, (DBCAS_t) meshnames, meshtypes, NULL);
For a longer explanation, see these notes.
With GCC 14, which makes implicit function declarations an error by default:
Fix the include guards and include unconditionally (for difftime) and unconditionally too (for memcpy).