search

LLNL / Tribol

Modular interface physics library featuring state-of-the-art contact physics methods.
MIT License
25 stars 2 forks source link

Index issue in `FE.cpp` function `InvIso()` #95

Closed zatkins-work closed 3 months ago

zatkins-work commented 3 months ago

In tribol::InvIso, the check that each component of xi is in [0,1] erroneously only checks the first component.

https://github.com/LLNL/Tribol/blob/4f9c9dc37502549d3135c63a6a7686affa4b7882/src/tribol/integ/FE.cpp#L348-L350

This may be causing some issues due to bad isoparametric coordinates not being detected.

srwopschall commented 3 months ago

@zatkins-work - Excellent find. Copy and paste error. Thanks for your work on this.