search

LLNL / UnifyFS

UnifyFS: A file system for burst buffers
Other
107 stars 31 forks source link

Should not assume file exist at a open call #776

Closed wangvsa closed 1 year ago

wangvsa commented 1 year ago

This is a small assumption issue. unifyfs_fid_open function assumes the file must exist after an open call. But the file may be opened without "O_CREAT" flag; For example, some applications use the open call to test for file existence. In this case, we should not print out an error (line 564). Fix: replace LOGERR to LOGDBG. I will create a PR to fix this.

https://github.com/LLNL/UnifyFS/blob/e07093fd88839f9619678f03e94f8917329e26cb/client/src/unifyfs_fid.c#L517-L566

MichaelBrim commented 1 year ago

@wangvsa Yes, I agree it shouldn't be treated as an error for logging purposes - LOGDBG is good. We should also change the message to remove the word "existing"