LLNL / axom

CS infrastructure components for HPC applications
BSD 3-Clause "New" or "Revised" License
158 stars 27 forks source link

BVH improvements #1429

Closed adayton1 closed 1 month ago

adayton1 commented 1 month ago

Summary

Current pattern

axom::spin::BVH<3> bvh;
bvh.setAllocatorID(allocatorID);
bvh.initialize(boxes, numBoxes);

New pattern

axom::spin::BVH<3> bvh(boxes, numBoxes, allocatorID);
adayton1 commented 1 month ago

My only concern is that initialize returns a bool indicating whether construction succeeds. But it looks like it always returns true, so it's probably not worth worrying about.

white238 commented 1 month ago

"Avoids unnecessary copy of each bounding box"

@adayton1 have you ever thought that maybe we want to do extra work?!?! Why do you have to make everything so efficient and better?

adayton1 commented 1 month ago

/style