LLNL / axom

CS infrastructure components for HPC applications
BSD 3-Clause "New" or "Revised" License
158 stars 27 forks source link

Move ItemCollection and derived classes to core #1443

Closed nselliott closed 3 weeks ago

nselliott commented 1 month ago

Summary

Moving these header-only classes required removing their dependencies on Slic, as there were a few uses of Slic assertions and warnings. Those have been replaced with raw assert() calls and output to std::cerr, matching what is done elsewhere in Axom core.

The definitions of constants InvalidIndex and InvalidName needed to be moved from Sidre into core for usage by the collection classes.

nselliott commented 3 weeks ago

Thanks @nselliott

Please update the RELEASE_NOTES with this change. Should add some unit tests to core for basic operations on these classes?

The existing set of unit tests for these classes in the sidre test directory is still good. We could move them to the core test directory if needed.