`mint::Mesh` unnecessarily requires coordinate arrays to be 2D (Nx1) arrays

LLNL / axom

CS infrastructure components for HPC applications

BSD 3-Clause "New" or "Revised" License

158 stars 27 forks source link

`mint::Mesh` unnecessarily requires coordinate arrays to be 2D (Nx1) arrays #1450

Open gunney1 opened 1 month ago

gunney1 commented 1 month ago

There may be a real reason for the requirement, but it is in excess of the Blueprint mesh convention. The requirement may be related to storing the 1D arrays in MCArray, which is deprecated. Maybe we should store them as axom::Array and remove the 2D requirement. That is, if the change doesn't break anything.

gunney1 commented 2 weeks ago

MR https://github.com/LLNL/axom/pull/1459 adds reshaping to sidre::View, so we can reshape the data to satisfy the mint::Mesh requirement. However, we may still want to consider removing the requirement if it is outdated.