search

LLNL / axom

CS infrastructure components for HPC applications
BSD 3-Clause "New" or "Revised" License
150 stars 27 forks source link

SLIC/Lumberjack: support formatting RANK_COUNT and RANKS #256

Closed white238 closed 1 month ago

white238 commented 4 years ago

Currently Lumberjack only reports the following through SLIC's formatting options ": ". It has been requested to be allowed to have more control of this and add both options.

@gzagaris you okay with this? or an alternate idea?

gzagaris commented 4 years ago

Hi @white238 -- generally I think I am OK with this.

To clarify, the request is to have both <RANK_COUNT>, which would print the total number of ranks that generated a log message and <RANKS> which prints the "first" N ranks that logged a particular message, where N is the threshold limit set in Lumberjack.

Is this correct?

white238 commented 4 years ago

Yepp..

rhornung67 commented 2 years ago

In addition, improve the reporting of which ranks generated the message. See also: https://github.com/LLNL/axom/issues/283

gberg617 commented 2 months ago

Hi @white238 -- generally I think I am OK with this.

To clarify, the request is to have both <RANK_COUNT>, which would print the total number of ranks that generated a log message and <RANKS> which prints the "first" N ranks that logged a particular message, where N is the threshold limit set in Lumberjack.

Is this correct?

@white238 @bmhan12 This comment above is particularly relevant right now for switching to SLIC. Would something like what's being suggested above still be possible?

white238 commented 2 months ago

This should be easy to implement, we just abstained due to the person who asked didn't get around to using SLIC/Lumberjack themselves and it was a breaking change. I can do it.