LLNL / benchpark

An open collaborative repository for reproducible specifications of HPC benchmarks and cross site benchmarking environments
https://software.llnl.gov/benchpark/
Apache License 2.0
27 stars 24 forks source link

adding r-ccs genesis app with simple regression test as workload #260

Closed jdomke closed 2 months ago

jdomke commented 4 months ago

linter is complaining about:

Run black --diff --check .
All done! ✨ 🍰 ✨
7 files would be left unchanged.
./repo/genesis/application.py:36: equil ==> equal
./repo/genesis/application.py:39: equil ==> equal
./repo/genesis/application.py:42: equil ==> equal
./repo/qws/application.py:63: sovler ==> solver
Error: Process completed with exit code 65.

but sadly those are the names of inputs and text in output, so not something i can influence right now

pearce8 commented 4 months ago

@alecbcs What can be done to force linter to ignore these?

jdomke commented 3 months ago

genesis runs now. problem was due to a bug in our llvm.

jdomke commented 3 months ago

@alecbcs What can be done to force linter to ignore these?

i changed the regex slightly to fool the linter, seems a merge is now doable, please go ahead @pearce8

pearce8 commented 3 months ago

@scheibelp Please take a look, I hope you recall this error from before - and how we would fix it:

==> Error: /home/runner/work/benchpark/benchpark/workspace/genesis/openmp/RCCS-Fugaku-Fujitsu-A64FX-TofuD/workspace/configs/ramble.yaml:39 concretized: true

Additional properties are not allowed ('concretized' was unexpected)

scheibelp commented 3 months ago

The new error indicates to me you may need to merge latest benchpark into your branch:

jdomke commented 2 months ago

The new error indicates to me you may need to merge latest benchpark into your branch:

* [Update benchpark for ramble package manager abstraction #301](https://github.com/LLNL/benchpark/pull/301)  changed `spack.yaml` to `software.yaml` based on the new Ramble

* If the CI is based on an older Benchpark (using an older Ramble) that would explain why it's looking for (and failing to find) `spack.yaml`

fixed it

jdomke commented 2 months ago

The new error indicates to me you may need to merge latest benchpark into your branch:

* [Update benchpark for ramble package manager abstraction #301](https://github.com/LLNL/benchpark/pull/301)  changed `spack.yaml` to `software.yaml` based on the new Ramble

* If the CI is based on an older Benchpark (using an older Ramble) that would explain why it's looking for (and failing to find) `spack.yaml`

fixed it

ok, at least i tried, can you make sense of the current error @scheibelp ?

scheibelp commented 2 months ago

Thanks!