LLNL / benchpark

An open collaborative repository for reproducible specifications of HPC benchmarks and cross site benchmarking environments
https://software.llnl.gov/benchpark/
Apache License 2.0
25 stars 22 forks source link

Add options to customize execute_experiment.tpl #276

Closed scheibelp closed 2 months ago

scheibelp commented 2 months ago

Closes https://github.com/LLNL/benchpark/pull/258

New variables supported in variables.yaml:

This also provides a means to define a system or experiment-specific execute_experiment.tpl. The experiment can likewise choose to omit the allocation modifier, and thereby specify everything manually

scheibelp commented 2 months ago

@jdomke I'm curious if this PR addresses your needs

jdomke commented 2 months ago

@jdomke I'm curious if this PR addresses your needs

from a quick look at it, it seems to be doing what i needed, but i have not tried it, do you need me to verify it before you merge, or should i wait until after and debug if necessary?

scheibelp commented 2 months ago

do you need me to verify it before you merge, or should i wait until after and debug if necessary?

Whichever you prefer: it sounds like you are fine with it being merged before you get a chance to test it, so I'll proceed with that assumption unless you say otherwise.