search

LLNL / conduit

Simplified Data Exchange for HPC Simulations
https://software.llnl.gov/conduit/
Other
211 stars 65 forks source link

domain to rank map is wrong when domain ids aren't there #1140

Open cyrush opened 1 year ago

cyrush commented 1 year ago

this logic is wrong: https://github.com/LLNL/conduit/blob/5aef054fa682d7aa0ff307f7d034f16505f8991c/src/libs/blueprint/conduit_blueprint_mpi_mesh.cpp#L189

We need counting + offset b/c of multi domain.

nselliott commented 1 year ago

The current logic is that if it's multi-domain, there must be a state/domain_id, and that value overrides the par_rank value. If state/domain_id isn't there, it's assuming it's not multi-domain. This might be building in too many implicit assumptions, though.

cyrush commented 1 year ago

thanks @nselliott, got it -- at the moment we are hunting a mystery related to domain ids that are present, but I noticed this and I think we should upgrade the logic to be more robust.

cyrush commented 1 year ago

Also, to be clear -- the issue with domains ids is not a conduit problem, mystery lies elsewhere -- we are just using this method to help us as part of the debugging process.