search

LLNL / conduit

Simplified Data Exchange for HPC Simulations
https://software.llnl.gov/conduit/
Other
208 stars 64 forks source link

Use Data Accessor `set` to clean up generate sides further #1256

Closed JustinPrivitera closed 7 months ago

JustinPrivitera commented 7 months ago

Resolves #1243

Thanks to #1143, we can clean up generate_sides even more.

How does this look @cyrush?

BradWhitlock commented 7 months ago

What's the performance difference? I'm assuming it's slower.

JustinPrivitera commented 7 months ago

@BradWhitlock I will do some timings and report back.

JustinPrivitera commented 7 months ago

The timings are just about the same. We have a maybe 0.5% speedup with the changes I've made.

I think it's about the same because we were doing a whole lot of static casts before; not much has changed other than the way we do those casts.

cyrush commented 7 months ago

thanks @JustinPrivitera - data accessor is using the same basic strategy as the templating here, its just packaged into a simpler interface that is compiled once.