LLNL / conduit

Simplified Data Exchange for HPC Simulations
https://software.llnl.gov/conduit/
Other
207 stars 63 forks source link

Improve PH element extraction in partitioner #1260

Closed BradWhitlock closed 4 months ago

BradWhitlock commented 4 months ago

After finding that recombined PH domains get some faces wrong, I thought about why that could happen. It turns out that when the subset of PH zones are pulled out of their original mesh, they were grabbing their faces as-is. For zones that had a face that was defined first by another zone, it was necessary to reverse the face first before adding it into the new mesh subset. This change means that the normals are pointing in a more consistent direction (assuming the input mesh was well-behaved to begin with) when extracted chunks are recombined. I had to fix some partitioner baselines where faces got reversed, and I verified they are better now.