LLNL / conduit

Simplified Data Exchange for HPC Simulations
https://software.llnl.gov/conduit/
Other
207 stars 63 forks source link

Fix memory problems in flatten test #1269

Closed BradWhitlock closed 2 months ago

BradWhitlock commented 2 months ago

I ran the Conduit tests after having built with the Intel compiler and the flatten test failed again in a new way. I ran through valgrind and it found out of bounds reads for the braid _quads_andtris dataset. When I printed out that dataset, which gets used in flatten to make a 4x3 node mesh, it had some node ids that were larger than 11. The routine that made the connectivity was bad.

BradWhitlock commented 2 months ago

Wait a minute. I forgot to re-enable a test that started misbehaving.