search

LLNL / conduit

Simplified Data Exchange for HPC Simulations
https://software.llnl.gov/conduit/
Other
208 stars 64 forks source link

Some HDF5 dataspaces needed H5Sclose instead of H5Dclose #1277

Closed nselliott closed 4 months ago

nselliott commented 4 months ago

The HDF5 ids nodespace and dataspace here are dataspaces that need to be closed with H5Sclose, not with H5Dclose.

cyrush commented 4 months ago

@nselliott thanks for finding and resolving these cases!

nselliott commented 4 months ago

This does not resolve all user code issues.

rhornung67 commented 4 months ago

This does not resolve all user code issues.

That is awesome. I told Tom about it and I think he is trying it out.

nselliott commented 4 months ago

That is awesome. I told Tom about it and I think he is trying it out.

Note that I said it does not resolve it.