search

LLNL / conduit

Simplified Data Exchange for HPC Simulations
https://software.llnl.gov/conduit/
Other
208 stars 64 forks source link

trailing space in yaml output for object of objects case #1294

Open cyrush opened 2 months ago

cyrush commented 2 months ago

For example:

...dims:.
......i: 25
......j: 25
......z: 2
cyrush commented 2 months ago

https://github.com/LLNL/conduit/blob/7feab70184336b680d663bbbd3789791eadb2a37/src/libs/conduit/conduit_node.cpp#L12955

https://github.com/LLNL/conduit/blob/7feab70184336b680d663bbbd3789791eadb2a37/src/libs/conduit/conduit_node.cpp#L13026

https://github.com/LLNL/conduit/blob/7feab70184336b680d663bbbd3789791eadb2a37/src/libs/conduit/conduit_node.cpp#L13911

https://github.com/LLNL/conduit/blob/7feab70184336b680d663bbbd3789791eadb2a37/src/libs/conduit/conduit_node.cpp#L13931

cyrush commented 2 months ago

To fix, we would need to add logic to add the space if the child is a leaf.

Not sure if the juice is worth the squeeze.

rhornung67 commented 2 months ago

juice? squeeze? 😄