Closed slitvinov closed 4 years ago
This is a good point. fpzip installation instructions are for GNU make, which does define $^. GNU make is so pervasive today that I did not consider other versions of make (or that $^ wasn't defined).
I've pushed a fix on the develop
branch.
Thank you! We are using fpzip in our multiphase flows. https://github.com/cselab/aphros
Thanks for the pointer. If you don't mind, I'd like to link to your project off the fpzip related projects page.
I noticed that you are using fpzip to compress data as 1D arrays only, which it was not designed for. If any of the arrays being compressed are multidimensional, then I would strongly suggest compressing them as such, as you should see far higher compression ratios when all correlated dimensions are accounted for.
Thanks for your suggestion. We use compression to exchange data between cubic subdomains, so our arrays are actually two-dimensional. Sure, you can add our project.
I am using BSD Make to build fpzip. It does not define $^ macro which is not in POSIX [1].
libpzip builds without error but it does not include any object files because $^ expands to an empty string.
It gives me very hard to trace errors if I link with the libray.
I think Makefiles (https://github.com/LLNL/fpzip/blob/master/src/Makefile#L14) can be portable if one does
instead of
[1] https://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html