Fix Bug When Importing Roundtrip

LLNL / hatchet

Graph-indexed Pandas DataFrames for analyzing hierarchical performance data

https://llnl-hatchet.readthedocs.io

MIT License

29 stars 18 forks source link

Fix Bug When Importing Roundtrip #127

Closed michaelmckinsey1 closed 5 months ago

michaelmckinsey1 commented 5 months ago

Currently, Hatchet prints a TypeError in each Jupyter cell due to a missing positional argument in manage_jupter_change() in hatchet/external/roundtrip/roundtrip/manager.py. By adding and optional positional argument to the function, we avoid the error when this line is ran.

Additionally, the import statements are re-arranged to avoid importing the roundtrip module unintentionally, which is happening in the below image.

cscully-allison commented 5 months ago

These look good to me. Not sure why the unit tests are failing, but I couldn't see any side effects this would case.

ilumsden commented 5 months ago

@michaelmckinsey1 please rebase on develop. @pearce8 just merged #129, so you should be able to pull in the CI fixes by rebasing.