LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
201 stars 36 forks source link

Updates to README #106

Closed siuwuncheung closed 2 years ago

siuwuncheung commented 2 years ago

Adding a logo and a link to libROM webpage

kevinhkhuynh commented 2 years ago

Can you change

https://librom.net

to

https://www.librom.net or librom.net

This will remove the security risk warning that some browsers have when we try to connect to the top one.

siuwuncheung commented 2 years ago

Can you change

https://librom.net

to

https://www.librom.net or librom.net

This will remove the security risk warning that some browsers have when we try to connect to the top one.

Done, thanks @kevinhkhuynh !

kevinhkhuynh commented 2 years ago

It looks like PyTorch just embeds the image of their logo at the top of their README.md (https://github.com/pytorch/pytorch)

Maybe we can do the same using the librom.net logo?

I'm also good with what we currently have in the PR, with the text logo.

chldkdtn commented 2 years ago

It looks like PyTorch just embeds the image of their logo at the top of their README.md (https://github.com/pytorch/pytorch)

Maybe we can do the same using the librom.net logo?

I'm also good with what we currently have in the PR, with the text logo.

This looks like a good idea. @siuwuncheung Can you do this? The libROM logo can be found from romweb repo for our librom.net page.

siuwuncheung commented 2 years ago

It looks like PyTorch just embeds the image of their logo at the top of their README.md (https://github.com/pytorch/pytorch) Maybe we can do the same using the librom.net logo? I'm also good with what we currently have in the PR, with the text logo.

This looks like a good idea. @siuwuncheung Can you do this? The libROM logo can be found from romweb repo for our librom.net page.

Yes, I just updated the logo.

chldkdtn commented 2 years ago

@dylan-copeland @debog Let's review this and approve and merge.