search

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
201 stars 36 forks source link

gLaSDI update #126

Closed xiaolong7 closed 1 year ago

xiaolong7 commented 2 years ago

Converted notebook to Python scripts Updated README Corrected typos in src/error_utils.py

chldkdtn commented 2 years ago

@dylan-copeland @siuwuncheung @kevinhkhuynh where are we with this PR? Do we have enough review for this PR?

pranav-vempati commented 1 year ago

@xiaolong7 Is this PR still in a ready-for-review state, given the recent changes?

xiaolong7 commented 1 year ago

@xiaolong7 Is this PR still in a ready-for-review state, given the recent changes?

Yes, it is ready for review.

chldkdtn commented 1 year ago

@xiaolong7 I am going to close this PR because we have gLaSDI repo in a separate repo. Is it okay?

jtlau commented 1 year ago

Fine with me!

On Tue, May 2, 2023, 9:10 PM Youngsoo Choi @.***> wrote:

@xiaolong7 https://github.com/xiaolong7 I am going to close this PR because we have gLaSDI repo in a separate repo. Is it okay?

— Reply to this email directly, view it on GitHub https://github.com/LLNL/libROM/pull/126#issuecomment-1532435299, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPYY6UTEFLKPLIAULCX6G3XEHLCNANCNFSM5ZQ6PGQA . You are receiving this because your review was requested.Message ID: @.***>

chldkdtn commented 1 year ago

Closing this PR because we have public gLaSDI repo at https://github.com/LLNL/gLaSDI