search

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
201 stars 36 forks source link

Updating overlap method in Parametric DW-DMD #157

Closed siuwuncheung closed 1 year ago

siuwuncheung commented 1 year ago

By specifying rdim, we can now make sure each DMD model collects at least rdim snapshots.

pranav-vempati commented 1 year ago

Hi Tony, is this PR ready for review?

siuwuncheung commented 1 year ago

Hi Tony, is this PR ready for review?

Yes, it is RFR now. Again, the scripts local_dw_csv and parametric_dw_csv are designed only for DMD on the pore collapse data now, so there is no testing examples.

siuwuncheung commented 1 year ago

I am approving since there are no example runs and nothing to verify, and I just have one question which you probably thought about already. Does it still work in the case that rdim is not specified, so it has the default value of -1?

Yes, if rdim is not specified, then the overlap_count[curr_window] will just be windowOverlapSamples, which is the same as original.