search

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
201 stars 36 forks source link

Run regresssion tests on LGTM #163

Closed pranav-vempati closed 1 year ago

pranav-vempati commented 1 year ago

This PR modifies the CI to only run for PR commits, and runs the entire CI pipeline(unit and regression tests) only when the LGTM label is added to the PR.

dylan-copeland commented 1 year ago

@pranav-vempati will it be possible to trigger the pipeline multiple times in a PR, by removing and adding the LGTM label back? For example, if LGTM is added and the pipeline runs, then another commit is made, can we run the pipeline again by removing and adding LGTM?

pranav-vempati commented 1 year ago

@dylan-copeland Yes, it is possible to trigger the pipeline multiple times in a PR in that manner. Note that the act of creating the 'LGTM' label triggers the regression tests, not removing it.

dylan-copeland commented 1 year ago

@pranav-vempati does this PR ensure that (1) tests are run on every commit made after the LGTM label has been added, or (2) tests are run just once on the event that the LGTM label is added? Based on your comment above, I assume the answer is (2), but I wanted to confirm.

pranav-vempati commented 1 year ago

@dylan-copeland The answer is actually 1). The regression tests run in two cases: when the LGTM label is added, and for every subsequent PR commit while the LGTM label is still present. If the regression tests should not run, the LGTM label can be removed.