search

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
201 stars 36 forks source link

Time-Windowing DMD Implementation for the Wave Equation #168

Closed pranav-vempati closed 1 year ago

pranav-vempati commented 1 year ago

Time-Windowing DMD Implementation for the Wave Equation(MFEM Example #23).

chldkdtn commented 1 year ago

@pranav-vempati Please add this example in regression test.

pranav-vempati commented 1 year ago

@pranav-vempati Please add this example in regression test.

This can probably be added as a separate PR, what do you think @chldkdtn?

chldkdtn commented 1 year ago

@pranav-vempati Please add this example in regression test.

This can probably be added as a separate PR, what do you think @chldkdtn?

Does it require too much work to add example to regression test suites? Is it why you would like to make it a separate PR for regression test addition?

pranav-vempati commented 1 year ago

@pranav-vempati Please add this example in regression test.

This can probably be added as a separate PR, what do you think @chldkdtn?

Does it require too much work to add example to regression test suites? Is it why you would like to make it a separate PR for regression test addition?

This example would need to be added to master before a new regression test for this example can be added and tested. So it's probably best to add a regression test for this example as a small standalone PR.

chldkdtn commented 1 year ago

@pranav-vempati Please add this example in regression test.

This can probably be added as a separate PR, what do you think @chldkdtn?

Does it require too much work to add example to regression test suites? Is it why you would like to make it a separate PR for regression test addition?

This example would need to be added to master before a new regression test for this example can be added and tested. So it's probably best to add a regression test for this example as a small standalone PR.

Sounds good, @pranav-vempati

chldkdtn commented 1 year ago

@pranav-vempati everything resolved now?