Closed dreamer2368 closed 1 year ago
@debog @dylan-copeland @siuwuncheung @sullan2 Would you mind reviewing this PR?
@debog @dylan-copeland @siuwuncheung @sullan2 Would you mind reviewing this PR?
I think I am out of my depths here!
@debog @dylan-copeland @siuwuncheung @sullan2 Would you mind reviewing this PR?
I think I am out of my depths here!
Me too, and there are enough approvals already, so I will not review.
By using docker container, github ci test can contain only
libROM
-related parts for testing. Most installation steps for dependencies can be skipped, which can reduce the linux ci test time from about 15 mins to 5 mins..github/workflows/Dockerfile
.googletest
are pre-installed in the container:Install Linux Dependencies
./.github/workflows/checkout_repo
run: scripts/setup.sh
Set Swap Space
step is not needed any longer, because all dependencies are not installed within ci test. However, this step is still included in the CI test, just in case we may need extra space in the future.Note:
mfem
. While it necessitates manually updating the container occasionally, it also enables a stable CI test and development.Issue:
RandomizedSVDTest
is susceptible to round-off error, failing randomly on different machine. This affects the test result under the container. See Issue #193 . Commented the corresponding test until the issue is resolved by a separate pull request.TODO: