search

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
201 stars 36 forks source link

Add alternative DMD output basis option #181

Closed siuwuncheung closed 1 year ago

siuwuncheung commented 1 year ago

By default, alt_output_basis = false, meaning phi = WX.

dylan-copeland commented 1 year ago

@siuwuncheung is there a good reason for unit_tests/test_DMD.cpp to fail?

siuwuncheung commented 1 year ago

@siuwuncheung is there a good reason for unit_tests/test_DMD.cpp to fail?

I think it may be related to the function override of DMD, where the usage is confused by the additional option. I will fix it once I get a chance.

siuwuncheung commented 1 year ago

The failing unit test is due to the default value alt_output_basis = false, but the master branch is using the other basis. In this commit, the default is set to true and the unit test passed. I will retain the default value as false and make changes to the unit tests.

siuwuncheung commented 1 year ago

In this commit, the baseline values in the unit tests are changed accordingly, after default value is retained to alt_output_basis = false. Now the unit test passed.