search

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
198 stars 36 forks source link

Const vector print function #196

Closed JacobLotz closed 1 year ago

JacobLotz commented 1 year ago

This PR adds const labels to the print function of Vector such that const Vectors can be printed as well.

An alternative to adding const labels would be to copy the print function to a const version. However, I think this is unnecessary as the print function could be a const anyway.

An example where this is beneficial is in the case of printing the const singular values owned by for instance BasisGenerator generator. Printing these with

generator->getSingularValues()->print("sv");

will thrown an error.

The CI/mac test seems to fail. From what I understand this is not due to the added const labels.