LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
198 stars 36 forks source link

CI workflow for style check #226

Closed dreamer2368 closed 11 months ago

dreamer2368 commented 1 year ago

NOTE astyle does not stylize everything for us as intended, and developers should keep the code nice and clean by themselves to some extent. For example, Previously the line 551 of lib/algo/DMD.cpp looks strange due to its peculiarly long line:

    double* inverse_input = new double[d_phi_real_squared->numRows() *
                                                                     d_phi_real_squared->numColumns() * 2];

This is currently edited this way:

    const int dprs_row = d_phi_real_squared->numRows();
    const int dprs_col = d_phi_real_squared->numColumns();
    double* inverse_input = new double[dprs_row * dprs_col * 2];

Potentially there can be more lines that were somewhat carelessly written and might needs some manual edits. This PR does not intend to make all the fixes for this.