[feature/replace-lapack-with-lapacke] Replace Fortran LAPACK calls with calls to LAPACK's C language interface, LAPACKE

goxberry commented 5 years ago

Work in progress. Still to do:

[x] Replace dgesdd call in IncrementalSVD.C with its LAPACKE counterpart.
[x] Remove the Fortran name mangling detection from the GNU Autotools build system (specifically, in configure.ac)

The basic motivation behind this PR is to make it easier to maintain a CMake and a GNU Autotools build system -- the Fortran name mangling macros conflict, and rather than resort to ugly hacking, removing the Fortran calls seemed more expedient and portable. See also https://github.com/mfem/mfem/pull/1006, which does something similar with MFEM (but without smart pointers because I don't know how the MFEM team feels about that language feature).

goxberry commented 5 years ago

While building with CXXFLAGS="-fsanitize=address" (Address Sanitizer), I encountered a memory leak in IncrementalSVD. I don't know where it is yet, but don't merge this PR until it's fixed.

goxberry commented 5 years ago

Rebased on top of PR #25. This PR is now ready for review (and merging, assuming it passes review).

LLNL / libROM

[feature/replace-lapack-with-lapacke] Replace Fortran LAPACK calls with calls to LAPACK's C language interface, LAPACKE #24