search

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
201 stars 36 forks source link

Fix issue with Database class #276

Closed ckendrick closed 4 months ago

ckendrick commented 6 months ago

This adds a return statement to the base Database functions open() and create(). Without these, calls to endSamples() and writeSnapshot() would hang indefinitely printing newlines to screen.

This also adds a test to the CI that calls writeSnapshot() to catch this behavior in the future.

dylan-copeland commented 6 months ago

@ckendrick can you please provide an example test that demonstrates the issue?

ckendrick commented 6 months ago

@dylan-copeland this issue should occur if you run any example from the current upstream branch during the offline phase. This should happen to any code that calls endSamples() or writeSnapshot(). Some examples I tried were dg_advection_global_rom -offline poisson_global_rom -offline -f 1.0 -id 0

chldkdtn commented 5 months ago

@dylan-copeland would you review this PR again?

chldkdtn commented 5 months ago

@dreamer2368 do you approve this PR?

chldkdtn commented 4 months ago

@dylan-copeland we need your review again on this PR.