search

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
201 stars 36 forks source link

Fix dg_euler build #284

Closed dylan-copeland closed 4 months ago

dylan-copeland commented 5 months ago

MFEM PR 3598 was recently merged to the MFEM master branch, refactoring ex18(p). One change that causes build issues with libROM is that class RiemannSolver and some other classes were moved from the example to the library, in mfem/fem/hyperbolic.hpp. As a result, libROM fails to build with the latest MFEM. There are significant changes in MFEM, beyond just moving some classes to the library. Properly fixing dg_euler may take some careful work. In the meantime, to fix the build immediately, I simply renamed the classes in dg_euler.hpp with the prefix ROM_, to avoid ambiguity.

dylan-copeland commented 5 months ago

We need 1 more approval to fix the broken libROM build. @chldkdtn @siuwuncheung @dreamer2368