Fix libROM builds for OSX

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods

https://www.librom.net

Other

197 stars 36 forks source link

Fix libROM builds for OSX #287

Closed ckendrick closed 2 weeks ago

ckendrick commented 1 month ago

This should allow libROM to be compiled natively again on Mac OSX to fix an error while finding MPI_Fortran. A minor change to the linker flags was added to CMake when building on OSX due to changes made in XCode versions 15.0+ (see https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking).

This was tested on OSX Ventura 13.6.6 using AppleClang 15.0.0, gfortran 13.2.0, and open-mpi 4.1.5, with and without MFEM enabled.

dylan-copeland commented 1 month ago

On mac, I get this error for ./scripts/compile.sh -m: libROM/examples/prom/dg_advection_global_rom.cpp:275:5: error: reference to 'MPI_Session' is ambiguous MPI_Session mpi;

dylan-copeland commented 2 weeks ago

Could another reviewer please test on mac and approve?