search

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
201 stars 36 forks source link

Space-time sampling #54

Closed dylan-copeland closed 3 years ago

dylan-copeland commented 3 years ago

Implements space-time sampling and some space-time linear algebra.

kevinhkhuynh commented 3 years ago

Will there be any libROM-specific tests for this PR? Or will the tests reside in Laghos?

dylan-copeland commented 3 years ago

Will there be any libROM-specific tests for this PR? Or will the tests reside in Laghos?

For now the testing is just in Laghos. Currently libROM has some small tests for spatial sampling, e.g. DEIM, GNAT. We could add some small tests like those, but it would take a bit of work. I guess the DEIM tests were made just by running DEIM to get output and verifying that output does not change. I don't see a good way to set up a test without using the code to generate results in the first place.

chldkdtn commented 3 years ago

Will there be any libROM-specific tests for this PR? Or will the tests reside in Laghos?

For now the testing is just in Laghos. Currently libROM has some small tests for spatial sampling, e.g. DEIM, GNAT. We could add some small tests like those, but it would take a bit of work. I guess the DEIM tests were made just by running DEIM to get output and verifying that output does not change. I don't see a good way to set up a test without using the code to generate results in the first place.

I am okay not to have a unit test in this PR, but in next PR, please add unit test that is similar to the ones for DEIM and GNAT.