search

LLNL / libROM

Model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
201 stars 36 forks source link

Feature/introduce mfem #64

Closed kevinhkhuynh closed 3 years ago

kevinhkhuynh commented 3 years ago

New instructions to compile are in the README.md.

kevinhkhuynh commented 3 years ago

To test the MFEM examples. Can cd into build and run ./ex1p and ./ex16p after building libROM with the -m option.

kevinhkhuynh commented 3 years ago

Thanks Kevin, this looks good. One comment I have, which does not need to be addressed in this PR, is that SampleMesh.hpp has implementation specific for two spaces (L2, H1), which is valid for mixed diffusion (L2 for pressure, H1 for velocity) and hydrodynamics (L2 for energy, H1 for x, v), but not completely general. For ex1p, we may need a version for a single space (H1). That is something we can do in a future PR.

Sounds good to me.

chldkdtn commented 3 years ago

@kevinhkhuynh @dylan-copeland @siuwuncheung Let's say if any PR got at least two approvals, then the PR can be merged. How is that?

chldkdtn commented 3 years ago

@kevinhkhuynh This needs to be merged.