search

LLNL / libROM

Data-driven model reduction library with an emphasis on large scale parallelism and linear subspace methods
https://www.librom.net
Other
204 stars 36 forks source link

add new interpolation methods #85

Closed kevinhkhuynh closed 2 years ago

kevinhkhuynh commented 2 years ago

Add inverse distance weighting and lagrangian polynomial methods to matrix interpolation.

Switch linear solver and fix bug relating to linear solver.

chldkdtn commented 2 years ago

Very nice!

chldkdtn commented 2 years ago

@dylan-copeland, Kevin told me that you are going to fix the compilation error related to "CreateSampleMesh" arguments.

chldkdtn commented 2 years ago

@kevinhkhuynh Do we have regression or unit test for all these mfem examples in librom?

dylan-copeland commented 2 years ago

The build issue is fixed in master now.

kevinhkhuynh commented 2 years ago

@kevinhkhuynh Do we have regression or unit test for all these mfem examples in librom?

Can you clarify what you mean by regression test for the mfem examples? Is this a test to ensure that the mfem examples run?

chldkdtn commented 2 years ago

@kevinhkhuynh Do we have regression or unit test for all these mfem examples in librom?

Can you clarify what you mean by regression test for the mfem examples? Is this a test to ensure that the mfem examples run?

The regression tests are useful to make sure that any future additional implementation does not break the existing capabilities of libROM. For example, the matrix manifold interpolation capability can be checked by comparing the results of this PR with any future results that might be altered by the future addition. We already have regression tests in LaghosROM, right? This is what I meant by "regression test."

kevinhkhuynh commented 2 years ago

@kevinhkhuynh Do we have regression or unit test for all these mfem examples in librom?

Can you clarify what you mean by regression test for the mfem examples? Is this a test to ensure that the mfem examples run?

The regression tests are useful to make sure that any future additional implementation does not break the existing capabilities of libROM. For example, the matrix manifold interpolation capability can be checked by comparing the results of this PR with any future results that might be altered by the future addition. We already have regression tests in LaghosROM, right? This is what I meant by "regression test."

Ah, I see. We do not have that functionality yet. We have a unit test capability, but not a regression test capability for the mfem examples. There isn't any unit tests for matrix interpolation yet, but I can see about adding some.