search

LLNL / lmt

Lustre Monitoring Tools
GNU General Public License v2.0
67 stars 21 forks source link

Update `_build_osd_stats_path` to work with current Lustre-Orion code #13

Closed prakashsurya closed 12 years ago

prakashsurya commented 12 years ago

The _build_osd_stats_path function assumes PROC_FS_LUSTRE_1_8_MDT_STATS in the case of _find_lustre_backfs_type (ctx) == BACKFS_ZFS.

For the current version of Orion:

lustre: 2.2.49.56
kernel: patchless_client
build:  orion-2_2_49_56_5-28chaos-28chaos--PRISTINE-2.6.32-220.7.1.7chaos.ch5.x86_64

This assumption is incorrect and PROC_FS_LUSTRE_2_0_MDT_STATS should be used.

I have tested the patch:

https://github.com/Prakash-Surya/lmt/commit/23fd9a80d006c3615e65a85cb443608e97cdcb47

And verified I can see the MDops/s number fluctuate as expected. Without the patch they all show 0.

behlendorf commented 12 years ago

Since we never expect anyone (including us) to use a lustre 1.8 derived zfs version, it probably just makes sense to have zfs imply PROC_FS_LUSTRE_2_0_MDT_STATS.

prakashsurya commented 12 years ago

OK. That works for me. I'll fix up a patch for that and send a pull request.