Closed FrankD412 closed 1 year ago
Just adding the link here for the live preview of this PR while we build this up: https://maestrowf--403.org.readthedocs.build/en/403/
Alright, WIP status removed, time for reviewing this beast
Front page: reproducability -> reproducibility
Getting Started:
pip install maestrowf
or at least a link to install instructions?Why Maestro:
Maestro page:
https://maestrowf--403.org.readthedocs.build/en/403/Philosophy/representation.html
https://maestrowf--403.org.readthedocs.build/en/403/Philosophy/principles.html
https://maestrowf--403.org.readthedocs.build/en/403/Maestro/index.html
https://maestrowf--403.org.readthedocs.build/en/403/Maestro/tutorials.html
https://maestrowf--403.org.readthedocs.build/en/403/Maestro/specification.html
tag
be a commit's SHA?
*batch block: is host really required? I thought it was ignoredhttps://maestrowf--403.org.readthedocs.build/en/403/Maestro/scheduling.html
https://maestrowf--403.org.readthedocs.build/en/403/Maestro/parameter_specification.html
https://maestrowf--403.org.readthedocs.build/en/403/Maestro/how_to_guides/timeouts.html
https://maestrowf--403.org.readthedocs.build/en/403/Maestro/how_to_guides/parameter_batches.html
API: I didn't look at it.
Alright, first pass at addressing review comments (thanks @doutriaux1 !). And one followup there to the question on host in the batch block that's not really addressed in the docs: while it is ignored by the scheduler in come cases, maestro's script adapters currently expect it to be there and will fail on a key error when trying to pop it off. It looks like there's no schema validation on these yet, so might be an opportunity for improvement there in a follow on pr to get early failures and better warning messages for the users.
This is a running PR to port over documentation to mkdocs and the Material theme.