LLNL / magpie

Magpie contains a number of scripts for running Big Data software in HPC environments, including Hadoop and Spark. There is support for Lustre, Slurm, Moab, Torque. LSF, Flux, and more.
GNU General Public License v2.0
195 stars 53 forks source link

PHOENIX_START_QUERYSERVER doesn't do anything #226

Closed bpanneton closed 8 years ago

bpanneton commented 8 years ago

There is an option in the Phoenix setup that doesn't do anything.

export PHOENIX_START_QUERYSERVER="yes"

# Set phoenix job for MAGPIE_JOB_TYPE = phoenix
#
# "performanceeval" - run performance evaluation write and read.
#              Useful for making sure things are setup the way you
#              like.
#
# "script" - execute a phoenix script indicated by PHOENIX_SCRIPT_PATH.
#            Unlike "script" in MAGPIE_JOB_TYPE, this script is
#            executed via the 'sqline.py' command.
#

I think we should use the option which makes sense, however it needs to be implemented in the code. Also the MODE should include interactive. (server is still implemented in the code)

This was likely due to this discussion: https://github.com/LLNL/magpie/issues/100

I wanted to check you didn't already have plans for something before I cleaned this up.

bpanneton commented 8 years ago

Kafka is this way as well except it seems like anything other than setuponly will start the service. Perhaps we should add interactive here as well.

bpanneton commented 8 years ago

And Zeppelin. With Kafka and Zeppelin maybe its just a documentation change.

bpanneton commented 8 years ago

And ZooKeeper

chu11 commented 8 years ago

For magpie 2.0, "interactive" is now only configurable in the "MAGPIE_JOB_TYPE" config at the top of the file. Basically, it was a waste to have "interactive" and "script" modes through all of the "MODE" variables (which are now "JOB" variables) even though they almost all did the same thing.

Does that clarify things?

bpanneton commented 8 years ago

Okay, it must have carried over to pre 2.0. Some, like zookeepr don't have the interactive option and use launch. I'll let this one be for now.

chu11 commented 8 years ago

Some projects like Zookeeper never had an interactive mode b/c it sort of didn't make sense for them.