search

LLNL / merlin

Machine Learning for HPC Workflows
MIT License
122 stars 26 forks source link

Release 1.9.0 #390

Closed ryannova closed 1 year ago

ryannova commented 1 year ago

Updated changes before release 1.9.0.

ryannova commented 1 year ago

I'm not sure if we are dropping support for 3.6. It seems more like that python 3.6 tests can't be run on github lately. I noticed this issue started on Tuesday. I'm not sure what is going on. The error I see on the checks are that it is unable to install python 3.6 stating that it doesn't exist.

lucpeterson commented 1 year ago

Bryan G has a PR in that drops 3.6 and adds 3.11. 3.6 is past end of life and GitHub runners don’t fully support them now. Let’s make the needdd changes on Bryan’s PR

—— J. Luc Peterson, PhD (he/him) LLNL @.***

On Dec 15, 2022, at 11:55 AM, Ryan Lee @.***> wrote:



I'm not sure if we are dropping support for 3.6. It seems more like that python 3.6 tests can't be run on github lately. I noticed this issue started on Tuesday. I'm not sure what is going on.

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https://github.com/LLNL/merlin/pull/390*issuecomment-1353633570__;Iw!!G2kpM7uM-TzIFchu!izr1Sletzuwh0Dj7M7B8K8b86PaeR-WBTFgxytP3Qcu1ehm1qQJyR32CEye2gvPeHR0$, or unsubscribehttps://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/AAEPYRFJAVWDLZNCLLVEUBDWNNZULANCNFSM6AAAAAATACZP54__;!!G2kpM7uM-TzIFchu!izr1Sletzuwh0Dj7M7B8K8b86PaeR-WBTFgxytP3Qcu1ehm1qQJyR32CEye2yCP8PSQ$. You are receiving this because your review was requested.Message ID: @.***>

ryannova commented 1 year ago

It seems like Brian's PR has already been approved. Are there any additional changes left? If not, do you want me to merge his changes in and update the release?

bgunnar5 commented 1 year ago

I haven't updated pypi, is this something I need to change in the codebase? The only changes I made so far regarding the 3.6 drop and 3.11 support were modifying the push-pr_workflow.yml file to remove 3.6 tests and add 3.11.

P.S. it's Brian with an i but I'll let it slide this time

lucpeterson commented 1 year ago

@ryannova can you de-conflict this with the PRs that just went in (@bgunnar5 and the GitHub bot that fixed a security concern)? Then I bet the tests will be passing and we can go ahead with it

koning commented 1 year ago

@bgunnar5 I think @lucpeterson needs to login to pypi and add you. It is just editing the information directly.