search

LLNL / merlin

Machine Learning for HPC Workflows
MIT License
122 stars 26 forks source link

Fix pylint errors #408

Closed bgunnar5 closed 1 year ago

bgunnar5 commented 1 year ago

This branch fixes almost all of the pylint errors we were seeing from the merlin/ and tests/ directories. I had to update the setup.cfg file to include some global disable flags for pylint.

bgunnar5 commented 1 year ago

I went back through this PR and cleaned up some additional pylint errors since I wasn't very consistent on when I fixed problems vs disabled them in my first run through. I added comments on some of the pylint errors I disabled and also added more info about pylint to the CHANGELOG.

The biggest changes you'll see are in batch.py but I think it makes the code easier to follow and easier to update going forward.

koning commented 1 year ago

I think the batch.py refactor should be in a separate PR. This PR should be for pylint changes.

lucpeterson commented 1 year ago

I’m seeing a lot of test failures that should be addressed

bgunnar5 commented 1 year ago

@koning I ended up refactoring it because of pylint errors in that file but I can move it to another branch instead. I think that's where my problems with the test suite are coming from at the moment anyways (even though they're passing locally for me).

bgunnar5 commented 1 year ago

@lucpeterson it's test 14 in the local test suite that's failing here for some reason. It runs just fine locally for me so I'm trying to debug at the moment. Maybe I'll just change this PR to a draft until it's fully ready.

bgunnar5 commented 1 year ago

Ok I just removed the batch refactor from this branch so this branch should be ready to merge now.