LLNL / merlin

Machine Learning for HPC Workflows
MIT License
118 stars 26 forks source link

feature/new-status #442

Closed bgunnar5 closed 11 months ago

bgunnar5 commented 1 year ago

I decided it would be best to split the refactor/status branch into 4 different branches:

  1. A branch for the merlin status command
  2. A branch for the merlin detailed-status command
  3. A branch for the merlin queue-info command
  4. A branch for all of the documentation for these commands

This is the branch for the merlin status changes and will most likely be the largest of the 4.

The refactored merlin status command in this PR contains the following functionality:

lucpeterson commented 11 months ago

Overall this looks fairly complete, with new and associated tests passing. The style seems good, with sufficient modularity. I think I’m ok with this (except above which is a nice to have): any detailed investigation would be of performance, scalability, etc and can be probably explored with additional improvements. In terms of a minimum viable product, I think this will suffice!

bgunnar5 commented 11 months ago

@lucpeterson I'll throw the docs in my final PR for this. If you want a look at them you can see them at #431

koning commented 11 months ago

I tried this PR, looks good.