Closed bgunnar5 closed 1 year ago
Looks good to me too
From: Joe Koning @.> Date: Friday, August 18, 2023 at 12:32 PM To: LLNL/merlin @.> Cc: Peterson, Luc @.>, Review requested @.> Subject: Re: [LLNL/merlin] bugfix/server-pip-redis-conf (PR #443)
@koning approved this pull request.
— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https:/github.com/LLNL/merlin/pull/443*pullrequestreview-1585114069__;Iw!!G2kpM7uM-TzIFchu!0Aqd-rQGO30bq__IJ3LI3Wd1wiWCl0RQGwtR0oIsvBCBj-dILk9WevkluuuHmmCGP_9lD9keN2m3MNBP6PJea9VeKbrx$, or unsubscribehttps://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/AAEPYRFJ4K3ND7R6CU6MHGDXV67KVANCNFSM6AAAAAA3V5XU7I__;!!G2kpM7uM-TzIFchu!0Aqd-rQGO30bq__IJ3LI3Wd1wiWCl0RQGwtR0oIsvBCBj-dILk9WevkluuuHmmCGP_9lD9keN2m3MNBP6PJeaw18zkCl$. You are receiving this because your review was requested.Message ID: @.***>
Does this work as well: export LC_ALL="C"
@koning I just tried it and yes it does. I'll add that to the docs too.
OK, good. The C just means ignore user encodings.
I added the *.conf to the recursive-include of the merlin server folder so that pip will add the redis.conf file to the wheel. I've also added a note on explaining how to fix an issue with
merlin server start
to get it to stop hanging.