Closed bgunnar5 closed 8 months ago
This branch is pretty much ready for review now but I think it needs tests. I'm working on refactoring the integration test suite at the moment so I'll likely leave this as a draft until that refactor is merged. The refactor will (hopefully) make writing tests much easier, especially for things like this.
Great, I'll look at this
Are there some tests we could make for this?
@lucpeterson I'm working on that at the moment. On a different branch I'm adding pytest fixtures for things like starting a redis server, creating a celery app, and launching workers to our integration test suite which will make writing integration tests more modular
@lucpeterson @koning @doutriaux1 Does this look ok to merge now?
This branch has the fix for the
merlin monitor
command so that it won't shut down an allocation if workers are still processing tasks for the spec that's given. This also required me to fix the currentmerlin status
command so that it no longer has inconsistencies when using Redis as the broker.